Re: [PATCH] firmware: stratix10-svc: Drop unnecessary checking for and populating /firmware/ node

[Richard Gong]

Hi,

On 4/28/20 3:32 AM, Sudeep Holla wrote:
> On Mon, Apr 27, 2020 at 02:12:56PM -0500, Richard Gong wrote:
> > Hi Sudeep,
> >
> > In our dts, firmware is not under root node. You can refer to
> > arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi for details.
> >
> > This is why we need check and populate firmware node.
>
> Ah that's bad. One of very few DTS I see firmware node not in the root.Per the Devicetree Specification, there is no need to define firmware 
under the root node. Some examples are fsl-ls1012a.dtsi and 
hi6220-hikey.dts.

> But this driver is the only one duplicating the codethen Commit 3aa0582fdb82 should be extended to handle firmware which is 
not defined under the root node. I am not sure if it is doable.
>
Regards,
Richard