Re: [PATCH v3 05/16] mfd: Add support for Kontron sl28cpld management controller

[Michael Walle]

Am 2020-04-28 14:50, schrieb Andy Shevchenko:
> On Thu, Apr 23, 2020 at 07:45:32PM +0200, Michael Walle wrote:
> > This patch adds core support for the board management controller found
> > on the SMARC-sAL28 board. It consists of the following functions:
> >  - watchdog
> >  - GPIO controller
> >  - PWM controller
> >  - fan sensor
> >  - interrupt controller
>
> ...
>
> >  obj-$(CONFIG_MFD_STMFX) 	+= stmfx.o
> >
> >  obj-$(CONFIG_SGI_MFD_IOC3)	+= ioc3.o
> > +
> > +obj-$(CONFIG_MFD_SL28CPLD)	+= sl28cpld.o
>
> Perhaps keep an order?

I don't see any order in that makefile. Looked to me like every new
file was added at the end.

> ...
>
> > +	return devm_mfd_add_devices(dev, -1, sl28cpld_devs,
>
> -1 has its own definition.

ok, I'll replace that by PLATFORM_DEVID_NONE.

Thanks,
-michael

> > +				    ARRAY_SIZE(sl28cpld_devs), NULL,
> > +				    i2c->irq, NULL);
> > +}