Re: [PATCH 2/5] coredump: Fix handling of partial writes in dump_emit()

[Linus Torvalds]

On Tue, Apr 28, 2020 at 9:34 AM Rob Landley <rob@xxxxxxxxxxx> wrote:
>
> Writes to a local filesystem should never be short unless disk full/error.

Well, that code is definitely supposed to also write to pipes.

But it also has "was I interrupted" logic, which stops the core dump.

So short writes can very much happen, it's just that they also imply
that the core dump should be aborted.

So the loop seems to be unnecessary. The situations where short writes
can happen are all the same situations where we want to abort anyway,
so the loop count should probably always be just one.

The same would go for any potential network filesystem with the
traditional NFS intr-like behavior.

            Linus