Re: [PATCH v3 2/2] of: property: Do not link to disabled devices
From: Rob Herring
Date: Tue Apr 28 2020 - 13:46:35 EST
On Mon, 20 Apr 2020 14:01:02 +0200, Nicolas Saenz Julienne wrote:
> When creating a consumer/supplier relationship between two devices,
> make sure the supplier node is actually active. Otherwise this will
> create a link relationship that will never be fulfilled. This, in the
> worst case scenario, will hang the system during boot.
>
> Note that, in practice, the fact that a device-tree represented
> consumer/supplier relationship isn't fulfilled will not prevent devices
> from successfully probing.
>
> Fixes: a3e1d1a7f5fc ("of: property: Add functional dependency link from DT bindings")
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@xxxxxxx>
>
> ---
>
> Changes since v2:
> - Correct code comment
> - Use already available return handling code
>
> Changes since v1:
> - Move availability check into the compatible search code and stop if
> node disabled
>
> drivers/of/property.c | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
Applied, thanks.
Rob