Re: [PATCH net-next] net: hns3: adds support for reading module eeprom info

[Jakub Kicinski]

On Tue, 28 Apr 2020 19:58:25 +0800 Huazhong Tan wrote:
> From: Yonglong Liu <liuyonglong@xxxxxxxxxx>
> 
> This patch adds support for reading the optical module eeprom
> info via "ethtool -m".
> 
> Signed-off-by: Yonglong Liu <liuyonglong@xxxxxxxxxx>
> Signed-off-by: Huazhong Tan <tanhuazhong@xxxxxxxxxx>

> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
> index 4d9c85f..8364e1b 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
> @@ -12,6 +12,16 @@ struct hns3_stats {
>  	int stats_offset;
>  };
>  
> +#define HNS3_MODULE_TYPE_QSFP		0x0C
> +#define HNS3_MODULE_TYPE_QSFP_P		0x0D
> +#define HNS3_MODULE_TYPE_QSFP_28	0x11
> +#define HNS3_MODULE_TYPE_SFP		0x03

Could you use the SFF8024_ID_* defines from sfp.h here as well?

Otherwise looks good to me!