Re: [PATCH net v2 2/2] net: phy: DP83TC811: Fix WoL in config init to be disabled

From: David Miller
Date: Tue Apr 28 2020 - 16:05:48 EST


From: Dan Murphy <dmurphy@xxxxxx>
Date: Mon, 27 Apr 2020 16:21:12 -0500

> + return phy_write_mmd(phydev, DP83822_DEVADDR,
^^^^^^^^^^^^^^^^

Please don't submit patches that have not even had a conversation with
the compiler.

This register define only exists in dp83822.c and you are trying to use
it in dp83tc811.c

If this doesn't compile, how did you do functional testing of this
change?

If you compile tested these changes against a tree other than the 'net'
tree, please don't do that.

Thanks.