Re: [PATCH net-next 4/4] net: phy: bcm54140: add second PHY ID

[Michael Walle]

Hi Andrew,

Am 2020-04-28 23:29, schrieb Andrew Lunn:
> On Tue, Apr 28, 2020 at 11:08:54PM +0200, Michael Walle wrote:
> > This PHY have to PHY IDs depending on its mode. Adjust the mask so 
> > that
> > it includes both IDs.
>
> Hi Michael
>
> I don't have a strong opinion, but maybe list it as two different
> PHYs? I do sometimes grep for PHY IDs, and that would not work due to
> the odd mask.

Me neither. I just looked odd to have actually the same PHY listed twice
with just another id. That makes me wonder if it is possible to have
the same PHY driver name twice. IIRC it is at leased used somewhere
in the sysfs. If that is true, I'd prefer to just have one PHY
"BCM54140" instead of a "BCM54140 (QSGMII)" and "BCM54140 (4x SGMII)".
Because it is actually the same PHY but only another interface towards
the MAC is used.

-michael