Re: [PATCH v7 08/12] arm: dts: s5pv210: Add node for SGX 540

[Jonathan Bakker]

Hi all,

On 2020-04-28 2:39 p.m., Jonathan Bakker wrote:
> Hi Krzysztof,
> 
> On 2020-04-27 8:46 a.m., Krzysztof Kozlowski wrote:
>> On Sun, Apr 26, 2020 at 07:57:12AM -0700, Jonathan Bakker wrote:
>>> Hi Paul,
>>>
>>> On 2020-04-26 5:56 a.m., Paul Cercueil wrote:
>>>>
>>>>
>>>> Le ven. 24 avril 2020 Ã 22:34, H. Nikolaus Schaller <hns@xxxxxxxxxxxxx> a Ãcrit :
>>>>> From: Jonathan Bakker <xc-racer2@xxxxxxx>
>>>>>
>>>>> All s5pv210 devices have a PowerVR SGX 540 (revision 120) attached.
>>>>>
>>>>> There is no external regulator for it so it can be enabled by default.
>>>>>
>>>>> Signed-off-by: Jonathan Bakker <xc-racer2@xxxxxxx>
>>>>> Signed-off-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>
>>>>> ---
>>>>> Âarch/arm/boot/dts/s5pv210.dtsi | 13 +++++++++++++
>>>>> Â1 file changed, 13 insertions(+)
>>>>>
>>>>> diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi
>>>>> index 2ad642f51fd9..abbdda205c1b 100644
>>>>> --- a/arch/arm/boot/dts/s5pv210.dtsi
>>>>> +++ b/arch/arm/boot/dts/s5pv210.dtsi
>>>>> @@ -512,6 +512,19 @@ vic3: interrupt-controller@f2300000 {
>>>>> ÂÂÂÂÂÂÂÂÂÂÂÂ #interrupt-cells = <1>;
>>>>> ÂÂÂÂÂÂÂÂ };
>>>>>
>>>>> +ÂÂÂÂÂÂÂ gpu: gpu@f3000000 {
>>>>> +ÂÂÂÂÂÂÂÂÂÂÂ compatible = "samsung,s5pv210-sgx540-120";
>>
>> This should not pass the bindings check because you missed last
>> compatibles.
>>
> 
> Thanks for pointing that out, I'll add it and make sure it passes the bindings check.
> 
>>>>> +ÂÂÂÂÂÂÂÂÂÂÂ reg = <0xf3000000 0x10000>;
>>>>> +ÂÂÂÂÂÂÂÂÂÂÂ interrupt-parent = <&vic2>;
>>>>> +ÂÂÂÂÂÂÂÂÂÂÂ interrupts = <10>;
>>>>> +ÂÂÂÂÂÂÂÂÂÂÂ clock-names = "core";
>>>>> +ÂÂÂÂÂÂÂÂÂÂÂ clocks = <&clocks CLK_G3D>;
>>>>> +
>>>>> +ÂÂÂÂÂÂÂÂÂÂÂ assigned-clocks = <&clocks MOUT_G3D>, <&clocks DOUT_G3D>;
>>>>> +ÂÂÂÂÂÂÂÂÂÂÂ assigned-clock-rates = <0>, <66700000>;
>>>>> +ÂÂÂÂÂÂÂÂÂÂÂ assigned-clock-parents = <&clocks MOUT_MPLL>;
>>>>
>>>> What are these clocks for, and why are they reparented / reclocked?
>>>>
>>>> Shouldn't they be passed to 'clocks' as well?
>>>>
>>>> -Paul
>>>>
>>>
>>> The G3D clock system can have multiple parents, and for stable operation
>>> it's recommended to use the MPLL clock as the parent (which in turn
>>> is actually a mux as well).  MOUT_G3D is simply the mux for CLK_G3D
>>> (SGX core clock), DOUT_G3D is the divider.  DOUT_G3D could equally be CLK_G3D
>>> (and probably should be, for readability) as CLK_G3D is simply the gate and
>>> DOUT_G3D is the divider for it.
>>
>> Good point, it should be CLK_G3D instead of DOUT.  Can you fix this as
>> well?
> 
> Yep, will do.  Nikolaus, I'll send you an updated patch to include.
> 

How are assigned-clocks handled in the yaml DT schema?  When running make dtbs_check,
I end up with messages such as

arch/arm/boot/dts/s5pv210-aquila.dt.yaml: gpu@f3000000: 'assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks' do not match any of the regexes: 'pinctrl-[0-9]+'

Do they need to explicitly be listed as valid entries?

Thanks,
Jonathan