Re: [PATCH v3] checkpatch: add dedicated checker for 'Fixes:' tag

From: Joe Perches
Date: Tue Apr 28 2020 - 19:17:08 EST


On Tue, 2020-04-28 at 09:10 -0700, Joe Perches wrote:
> On Tue, 2020-04-28 at 10:02 +0800, Wang YanQing wrote:
> > According to submitting-patches.rst, 'Fixes:' tag has a little
> > stricter condition about the one line summary:
> > ...
> > Do not split the tag across multiple
> > lines, tags are exempt from the "wrap at 75 columns" rule in order to simplify
> > parsing scripts
> > ...
> >
> > And there is no 'Fixes:' tag format checker in checkpatch to check
> > the commit id length too, so let's add dedicated checker to check
> > these conditions for 'Fixes:' tag.
>
> There's no need to duplicate functionality like this.
> Put this additional Fixes: logic into the existing block.
>
> (and don't take advise from Markus too seriously when it
> comes to English grammar or wording. He is not an arbiter
> of taste for this code)
>

btw: I suggested this patch last year.

https://lore.kernel.org/lkml/40bfc40958fca6e2cc9b86101153aa0715fac4f7.camel@xxxxxxxxxxx/