Re: [PATCH] mailbox: Fix NULL vs IS_ERR() check in zynqmp_ipi_mbox_probe()

From: Markus Elfring
Date: Wed Apr 29 2020 - 05:13:43 EST


> In case of error, the function devm_ioremap() returns NULL pointer
> not ERR_PTR().

Such information is helpful.


> The IS_ERR() test in the return value check should be replaced with NULL test.

Would you like to convert this description into an imperative wording?

Regards,
Markus