Re: [PATCH v3 3/4] gpio: thunderx: Utilize for_each_set_clump macro

[Andy Shevchenko]

On Wed, Apr 29, 2020 at 04:37:41AM +0530, Syed Nayyar Waris wrote:
> This patch reimplements the thunderx_gpio_set_multiple function in
> drivers/gpio/gpio-thunderx.c to use the new for_each_set_clump macro.
> Instead of looping for each bank in thunderx_gpio_set_multiple
> function, now we can skip bank which is not set and save cycles.

> +	const unsigned long bank_size = 64;

Shouldn't be rather definition?

-- 
With Best Regards,
Andy Shevchenko