Re: [PATCH 3/4 v2] firmware: stratix10-svc: Fix some error handling paths in stratix10_svc_drv_probe()

[Markus Elfring]

> While at it, also move a 'platform_device_put()' call to the error handling path.

How do you think about to use the message âComplete exception handling
in stratix10_svc_drv_probe()â in the final commit subject?


â
> +++ b/drivers/firmware/stratix10-svc.c
â
> @@ -1043,24 +1043,34 @@  static int stratix10_svc_drv_probe(struct platform_device *pdev)
â
> +	return 0;
> +
> +put_platform:
> +	platform_device_put(svc->stratix10_svc_rsu);
> +err_free_kfifo:
â
>  	return ret;
>  }


Can the label âerr_put_deviceâ be more appropriate for the improved
function implementation?
(Or: Would you like to omit the prefix âerr_â for these jump targets?)

Regards,
Markus