Re: [PATCH v3 4/6] blktrace: fix debugfs use after free

From: Christoph Hellwig
Date: Wed Apr 29 2020 - 08:04:27 EST


On Wed, Apr 29, 2020 at 12:02:30PM +0000, Luis Chamberlain wrote:
> > Err, that function is static and has two callers.
>
> Yes but that is to make it easier to look for who is creating the
> debugfs_dir for either the request_queue or partition. I'll export
> blk_debugfs_root and we'll open code all this.

No, please not. exported variables are usually a bad idea. Just
skip the somewhat pointless trivial static function.