Re: [f2fs-dev] [PATCH V2] f2fs: Avoid double lock for cp_rwsem during checkpoint

[Sayali Lokhande]

On 4/29/2020 6:14 PM, Dan Carpenter wrote:
> On Wed, Apr 29, 2020 at 10:28:36AM +0530, Sayali Lokhande wrote:
> > Hi Markus
> >
> > On 4/27/2020 4:08 PM, Markus Elfring wrote:
> > > > â This results in deadlock as
> > > > iput() tries to hold cp_rwsem, which is already held at the
> > > > beginning by checkpoint->block_operations().
> > > Will another imperative wording become helpful besides the provided information
> > > for this change description?
> > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=6a8b55ed4056ea5559ebe4f6a4b247f627870d4c#n151
> > >
> > > Would you like to add the tag âFixesâ because of adjustments
> > > for the data synchronisation?
> > I couldn't find any past commit which suits to be added under "Fixes" here.
> > Let me know if you have any other comment.
> This looks really old.  Maybe commit 399368372ed9 ("f2fs: introduce a
> new global lock scheme")?
Yes. Let me update it in Fixes tag in V3 and post it. Thanks for 
pointing it.
> regards,
> dan carpenter