Re: [PATCH v4 3/4] thermal/drivers/cpuidle_cooling: Change the registration function

[Lukasz Luba]

Hi Daniel,

On 4/29/20 11:36 AM, Daniel Lezcano wrote:
> Today, there is no user for the cpuidle cooling device. The targetted
> platform is ARM and ARM64.
>
> The cpuidle and the cpufreq cooling device are based on the device tree.
>
> As the cpuidle cooling device can have its own configuration depending
> on the platform and the available idle states. The DT node description
> will give the optional properties to set the cooling device up.
>
> Do no longer rely on the CPU node which is prone to error and will
> lead to a confusion in the DT because the cpufreq cooling device is
> also using it. Let initialize the cpuidle cooling device with the DT
> binding.
>
> This was tested on:
>   - hikey960
>   - hikey6220
>   - rock960
>   - db845c
>
> Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> ---
>   - V4:
>     - Changed message from pr_info to pr_debug
>     - Fixed of properties to comply with the binding
>     - Add a debug message int case the thermal-idle node is not found
>     - Do not return an error as the caller won't care
> ---

Looks good.

Reviewed-by: Lukasz Luba <lukasz.luba@xxxxxxx>

Regards,
Lukasz