Re: [PATCH 2/3] docs: sysctl/kernel: document ftrace entries
From: Stephen Kitt
Date: Wed Apr 29 2020 - 17:34:20 EST
On Tue, 28 Apr 2020 12:41:33 -0600, Jonathan Corbet <corbet@xxxxxxx> wrote:
> On Thu, 23 Apr 2020 20:36:50 +0200
> Stephen Kitt <steve@xxxxxxx> wrote:
> > Based on the ftrace documentation, the tp_printk boot parameter
> > documentation, and the implementation in kernel/trace/trace.c.
> >
> > Signed-off-by: Stephen Kitt <steve@xxxxxxx>
>
> This one could benefit from an ack from Steve (CC'd). Also one other
> little nit below:
Thanks (and thanks for the review Steve). Iâll follow up with v2 shortly,
fixing the spelling and grammar here:
> > +the console. This is very useful for capturing traces that lead to
> > +crashes and outputing it to a serial console.
in addition to this:
> > +will stop tracepoints from being sent to printk(), and
> > +
> > +::
>
> I would just make that ", and::" and avoid the separate line.
Regards,
Stephen
Attachment:
pgpyoPpZqeFIq.pgp
Description: OpenPGP digital signature