Re: [PATCH] scsi: qla2xxx: use true,false for need_mpi_reset

From: himanshu . madhani
Date: Thu Apr 30 2020 - 09:20:18 EST




On 4/30/20 7:17 AM, Jason Yan wrote:
Fix the following coccicheck warning:

drivers/scsi/qla2xxx/qla_tmpl.c:1031:6-20: WARNING: Assignment of 0/1 to
bool variable
drivers/scsi/qla2xxx/qla_tmpl.c:1062:3-17: WARNING: Assignment of 0/1 to
bool variable

Signed-off-by: Jason Yan <yanaijie@xxxxxxxxxx>
---
drivers/scsi/qla2xxx/qla_tmpl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_tmpl.c b/drivers/scsi/qla2xxx/qla_tmpl.c
index 819c46f31c05..281973b317a8 100644
--- a/drivers/scsi/qla2xxx/qla_tmpl.c
+++ b/drivers/scsi/qla2xxx/qla_tmpl.c
@@ -1028,7 +1028,7 @@ void
qla27xx_mpi_fwdump(scsi_qla_host_t *vha, int hardware_locked)
{
ulong flags = 0;
- bool need_mpi_reset = 1;
+ bool need_mpi_reset = true;
#ifndef __CHECKER__
if (!hardware_locked)
@@ -1059,7 +1059,7 @@ qla27xx_mpi_fwdump(scsi_qla_host_t *vha, int hardware_locked)
"-> fwdt1 fwdump residual=%+ld\n",
fwdt->dump_size - len);
} else {
- need_mpi_reset = 0;
+ need_mpi_reset = false;
}
vha->hw->mpi_fw_dump_len = len;


Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>

--
Himanshu Madhani
Oracle Linux Engineering