Re: [PATCH v11 2/5] usb: renesas-xhci: Add the renesas xhci driver

[Vinod Koul]

On 30-04-20, 17:36, Mathias Nyman wrote:
> On 30.4.2020 13.10, Vinod Koul wrote:
> > From: Christian Lamparter <chunkeey@xxxxxxxxxxxxxx>
> > 
> > This add a new driver for renesas xhci which is basically a firmware
> > loader for uPD720201 and uPD720202 w/o ROM. It uses xhci-pci driver for
> > most of the work.
> > 
> > This is added in Makefile before the xhci-pci driver so that it first
> > get probed for renesas devices before the xhci-pci driver has a chance
> > to claim any device.
> 
> Most of the above is no longer correct

Yes that is correct now, this para need to go.

> > diff --git a/drivers/usb/host/Makefile b/drivers/usb/host/Makefile
> > index b191361257cc..c3a79f626393 100644
> > --- a/drivers/usb/host/Makefile
> > +++ b/drivers/usb/host/Makefile
> > @@ -70,7 +70,8 @@ obj-$(CONFIG_USB_OHCI_HCD_DAVINCI)	+= ohci-da8xx.o
> >  obj-$(CONFIG_USB_UHCI_HCD)	+= uhci-hcd.o
> >  obj-$(CONFIG_USB_FHCI_HCD)	+= fhci.o
> >  obj-$(CONFIG_USB_XHCI_HCD)	+= xhci-hcd.o
> > -obj-$(CONFIG_USB_XHCI_PCI)	+= xhci-pci.o
> > +usb-xhci-pci-objs		:= xhci-pci.o xhci-pci-renesas.o
> > +obj-$(CONFIG_USB_XHCI_PCI)	+= usb-xhci-pci.o
> 
> I don't think it's a good idea to rename the xhci-pci module to usb-xhci-pci
> 
> does
> 
> xhci-pci-y			:= xhci-pci.o xhci-pci-renesas.o
> obj-$(CONFIG_USB_XHCI_PCI)	+= xhci-pci.o
> 
> cause some kbuild issues?

Yes with this version I get the warning:
make[4]: Circular drivers/usb/host/xhci-pci.o <- drivers/usb/host/xhci-pci.o dependency dropped.

I don't speak enough Kbuild, but I guess it does make sense that we have
xhci-pci.o as target for both xhci-pci.o xhci-pci-renesas.o! That was
the reason for adding usb tag to this to resolve the conflict.

I am okay for any other mechanism which can work well here. Btw what
issues do you foresee with adding usb tag to module name.

-- 
~Vinod