Re: [RFC PATCH v11 6/9] media: tegra: Add Tegra210 Video input driver

[Sowjanya Komatineni]

On 4/30/20 6:34 AM, Dmitry Osipenko wrote:
> 30.04.2020 01:00, Sowjanya Komatineni ÐÐÑÐÑ:
> > +static int tegra_csi_init(struct host1x_client *client)
> > +{
> > +	struct tegra_csi *csi = host1x_client_to_csi(client);
> > +	struct tegra_video_device *vid = dev_get_drvdata(client->host);
> > +	int ret;
> > +
> > +	INIT_LIST_HEAD(&csi->csi_chans);
> > +
> > +	ret = tegra_csi_tpg_channels_alloc(csi);
> > +	if (ret < 0) {
> > +		dev_err(csi->dev,
> > +			"failed to allocate tpg channels: %d\n", ret);
> > +		goto cleanup;
> > +	}
> > +
> > +	ret = tegra_csi_channels_init(csi);
> > +	if (ret < 0)
> > +		goto cleanup;
> > +
> > +	vid->csi = csi;
> > +
> > +	return 0;
> > +
> > +cleanup:
> > +	tegra_csi_channels_cleanup(csi);
> > +	pm_runtime_put_sync(csi->dev);
> This pm_runtime_put_sync() should be removed.

Sorry, I had it correct in follow-up patches and missed this to remove 
in v12.

Will double check all changes before sending v12 once all v11 feedback 
from you is done.

> > +	return ret;
> > +}