Re: [PATCH v2 2/2] iio: adc: ti-ads8344: optimize consumption

From: Alexandre Belloni
Date: Thu Apr 30 2020 - 16:18:06 EST


Hi,

On 18/04/2020 16:13:22+0100, Jonathan Cameron wrote:
> On Thu, 16 Apr 2020 22:54:28 +0200
> Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx> wrote:
>
> > Set the clock mode only once, at probe time and then keep the ADC powered
> > down between conversions.
> >
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
> Looks fine to me. I'd like to be lazy and not take this until the fix is
> in my upstream (even though I suspect the merge would be fine).
>
> Give me a poke if I seem to have forgotten this after that is true!
>

It now landed in your upstream but I guess you want to take Gregory's
patch as a fix first. To be honest I don't think any of the fixes are
urgent as it seems we are the only users of the particular ADC.


--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com