Re: [RFC PATCH V2 1/9] include/linux/pagemap.h: introduce attach/clear_page_private

[Guoqing Jiang]

On 5/1/20 3:49 AM, Al Viro wrote:
> On Fri, May 01, 2020 at 02:42:29AM +0100, Al Viro wrote:
> > On Thu, Apr 30, 2020 at 03:13:38PM -0700, Matthew Wilcox wrote:
> >
> > > > +/**
> > > > + * clear_page_private - clear page's private field and PG_private.
> > > > + * @page: page to be cleared.
> > > > + *
> > > > + * The counterpart function of attach_page_private.
> > > > + * Return: private data of page or NULL if page doesn't have private data.
> > > > + */
> > > Seems to me that the opposite of "attach" is "detach", not "clear".
> > Or "remove", perhaps...
> Actually, "detach" is better - neither "clear" nor "remove" imply "... and give
> me what used to be attached there", as this thing is doing.

Ok, seems we have reached the agreement about the new name ;-), will 
follow the instruction.

Thanks & Regards,
Guoqing