RE: [PATCH char-misc-next] crypto: xilinx: Handle AES PM API return status

[Rajan Vaja]

Thanks Gerg for review.

I have updated reported by and fixes tag properly now. Sent v2.

Thanks
Rajan

> -----Original Message-----
> From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> Sent: Friday, May 1, 2020 4:00 PM
> To: Rajan Vaja <RAJANV@xxxxxxxxxx>
> Cc: herbert@xxxxxxxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx; Kalyani Akula
> <kalyania@xxxxxxxxxx>; Michal Simek <michals@xxxxxxxxxx>; Jolly Shah
> <JOLLYS@xxxxxxxxxx>; linux-crypto@xxxxxxxxxxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH char-misc-next] crypto: xilinx: Handle AES PM API return
> status
> 
> CAUTION: This message has originated from an External Source. Please use
> proper judgment and caution when opening attachments, clicking links, or
> responding to this email.
> 
> 
> On Fri, May 01, 2020 at 03:14:51AM -0700, Rajan Vaja wrote:
> > Fixes: bc86f9c54616 ("firmware: xilinx: Remove eemi ops for aes
> > engine")
> >
> > Return value of AES PM API is not handled which may result in
> > unexpected value of "status" in zynqmp_pm_aes_engine().
> >
> > Consider "status" value as valid only if AES PM API is successful.
> >
> > Signed-off-by: Rajan Vaja <rajan.vaja@xxxxxxxxxx>
> 
> No "Reported-by:" line?
> 
> And put the "Fixes:" line down in the s-o-b area please.
> 
> thanks,
> 
> greg k-h