Re: [PATCH v4 01/10] loop: Factor out loop size validation

From: Martijn Coenen
Date: Fri May 01 2020 - 07:33:27 EST


Hi Ming,

On Wed, Apr 29, 2020 at 4:12 PM Ming Lei <ming.lei@xxxxxxxxxx> wrote:
> Now sector_t has been switched to u64 unconditionally, do we still need such
> validation?

I think you're right; I hadn't seen that change, but truncating
because of sector_t shouldn't be an issue anymore. I wondered if we
could actually have a smaller loff_t, but looks like that is 'long
long', which should always be 8 bytes as well. I might send this as a
separate patch, I don't want to drag this series on for too long.

Thanks,
Martijn

>
>
> Thanks,
> Ming
>
>