Re: [PATCH 0/2] perf stat: Support overall statistics for interval mode

[Jin, Yao]

On 5/1/2020 7:36 PM, Jiri Olsa wrote:
> On Thu, Apr 30, 2020 at 11:07:38AM +0800, Jin Yao wrote:
> > Currently perf-stat supports to print counts at regular interval (-I),
> > but it's not very easy for user to get the overall statistics.
> >
> > With this patchset, it supports to report the summary at the end of
> > interval output.
> >
> > For example,
> >
> >   root@kbl-ppc:~# perf stat -e cycles -I1000 --interval-count 2
> >   #           time             counts unit events
> >        1.000412064          2,281,114      cycles
> >        2.001383658          2,547,880      cycles
> >
> >    Performance counter stats for 'system wide':
> >
> >            4,828,994      cycles
> >
> >          2.002860349 seconds time elapsed
> >
> >   root@kbl-ppc:~# perf stat -e cycles,instructions -I1000 --interval-count 2
> >   #           time             counts unit events
> >        1.000389902          1,536,093      cycles
> >        1.000389902            420,226      instructions              #    0.27  insn per cycle
> >        2.001433453          2,213,952      cycles
> >        2.001433453            735,465      instructions              #    0.33  insn per cycle
> >
> >    Performance counter stats for 'system wide':
> >
> >            3,750,045      cycles
> >            1,155,691      instructions              #    0.31  insn per cycle
> >
> >          2.003023361 seconds time elapsed
> >
> >   root@kbl-ppc:~# perf stat -M CPI,IPC -I1000 --interval-count 2
> >   #           time             counts unit events
> >        1.000435121            905,303      inst_retired.any          #      2.9 CPI
> >        1.000435121          2,663,333      cycles
> >        1.000435121            914,702      inst_retired.any          #      0.3 IPC
> >        1.000435121          2,676,559      cpu_clk_unhalted.thread
> >        2.001615941          1,951,092      inst_retired.any          #      1.8 CPI
> >        2.001615941          3,551,357      cycles
> >        2.001615941          1,950,837      inst_retired.any          #      0.5 IPC
> >        2.001615941          3,551,044      cpu_clk_unhalted.thread
> >
> >    Performance counter stats for 'system wide':
> >
> >            2,856,395      inst_retired.any          #      2.2 CPI
> >            6,214,690      cycles
> >            2,865,539      inst_retired.any          #      0.5 IPC
> >            6,227,603      cpu_clk_unhalted.thread
> >
> >          2.003403078 seconds time elapsed
> >
> > Jin Yao (2):
> >    perf evsel: Create counts for collecting summary data
> >    perf stat: Report summary for interval mode
>
> good idea, but I can't apply this on latest Arnaldo's perf/core,
> could you please rebase?
>
> thanks,
> jirka

Oh, yes, it couldn't be applied on perf/core. I've rebased it.

Thanks
Jin Yao

> >   tools/perf/builtin-stat.c | 14 ++++++-
> >   tools/perf/util/evsel.c   | 10 ++++-
> >   tools/perf/util/evsel.h   |  1 +
> >   tools/perf/util/stat.c    | 77 +++++++++++++++++++++++++++++++++++++++
> >   tools/perf/util/stat.h    |  5 +++
> >   5 files changed, 103 insertions(+), 4 deletions(-)
> >
> > --
> > 2.17.1