Re: [PATCH v2 04/10] power: separate PageHighMem() and PageHighMemZone() use case

[Joonsoo Kim]

2020ë 5ì 1ì (ê) ìí 9:22, Christoph Hellwig <hch@xxxxxxxxxxxxx>ëì ìì:
>
> On Wed, Apr 29, 2020 at 12:26:37PM +0900, js1304@xxxxxxxxx wrote:
> > index 6598001..be759a6 100644
> > --- a/kernel/power/snapshot.c
> > +++ b/kernel/power/snapshot.c
> > @@ -1227,7 +1227,7 @@ static struct page *saveable_highmem_page(struct zone *zone, unsigned long pfn)
> >       if (!page || page_zone(page) != zone)
> >               return NULL;
> >
> > -     BUG_ON(!PageHighMem(page));
> > +     BUG_ON(!PageHighMemZone(page));
>
> The above check already checks for the highmem zone.  So if we want
> to keep the BUG_ON it needs stay PageHighMem to make sense.  That being
> said I'd rather remove it entirelá.

Okay.

> > -     BUG_ON(PageHighMem(page));
> > +     BUG_ON(PageHighMemZone(page));
>
> Same here.

Okay.

Thanks.