Re: [PATCH v5] ARM: DTS: Aspeed: Add YADRO Nicole BMC

From: Andrew Jeffery
Date: Mon May 04 2020 - 07:04:30 EST




On Mon, 27 Apr 2020, at 20:41, Joel Stanley wrote:
> On Fri, 24 Apr 2020 at 13:53, Alexander Filippov <a.filippov@xxxxxxxxx> wrote:
> >
> > Nicole is an OpenPower machine with an Aspeed 2500 BMC SoC manufactured
> > by YADRO.
> >
> > Signed-off-by: Alexander Filippov <a.filippov@xxxxxxxxx>
>
> This looks good to me.
>
> Andrew, do you have any comments before I merge?

Not other than muxing all the ADC lines to enable just one seems a bit strange,
but Alexander mentioned previously that the rest were simply grounded so it's
not going to cause any problems in practice.

Andrew