Re: [PATCH v5] ARM: DTS: Aspeed: Add YADRO Nicole BMC
From: Andrew Jeffery
Date: Mon May 04 2020 - 09:24:09 EST
On Mon, 4 May 2020, at 22:14, Joel Stanley wrote:
> On Mon, 4 May 2020 at 11:04, Andrew Jeffery <andrew@xxxxxxxx> wrote:
> >
> >
> >
> > On Mon, 27 Apr 2020, at 20:41, Joel Stanley wrote:
> > > On Fri, 24 Apr 2020 at 13:53, Alexander Filippov <a.filippov@xxxxxxxxx> wrote:
> > > >
> > > > Nicole is an OpenPower machine with an Aspeed 2500 BMC SoC manufactured
> > > > by YADRO.
> > > >
> > > > Signed-off-by: Alexander Filippov <a.filippov@xxxxxxxxx>
> > >
> > > This looks good to me.
> > >
> > > Andrew, do you have any comments before I merge?
> >
> > Not other than muxing all the ADC lines to enable just one seems a bit strange,
> > but Alexander mentioned previously that the rest were simply grounded so it's
> > not going to cause any problems in practice.
>
> Thanks. Can you say the magic words for patchwork to pick up?
>
Acked-by: Andrew Jeffery <andrew@xxxxxxxx>