Re: [PATCH] net: rtw88: fix an issue about leak system resources

[Markus Elfring]

>>> the related system resources were not released when pci_iomap() return
>>> error in the rtw_pci_io_mapping() function. add pci_release_regions() to
>>> fix it.
>>
>> How do you think about a wording variant like the following?
>>
>>    Subject:
>>    [PATCH v2] net: rtw88: Complete exception handling in rtw_pci_io_mapping()
>>
>>    Change description:
>>    A call of the function âpci_request_regionsâ can fail here.
>>    The corresponding system resources were not released then.
>>    Thus add a call of the function âpci_release_regionsâ.
>>
>>
> Markus, I think my commit comments is a sufficiently clear description
> for this patch.

I got an other impression for specific aspects.


> Someone has told me not to send commit comments again and again
> when it is enough clear.

My patch review tries should give you hints where I noticed wording weaknesses.
The corresponding change tolerance can vary by involved contributors.


> Because it only wastes the precious time of the maintainer
> and very very little help for patch improvement.

I hope that also your commit messages will improve.


> BTW, In the past week, you asked me to change the commit comments in my
> 6 patches like this one. Let me return to the essence of patch, point
> out the code problems and better solutions will be more popular.

I would appreciate if various update suggestions would become nicer somehow.

Regards,
Markus