Re: [PATCH kvm-unit-tests] svm: Fix nmi hlt test to fail test correctly

From: Paolo Bonzini
Date: Mon May 04 2020 - 12:36:02 EST


On 28/04/20 20:41, Cathy Avery wrote:
> The last test does not return vmmcall on fail resulting
> in passing the entire test.
>
> Signed-off-by: Cathy Avery <cavery@xxxxxxxxxx>
> ---
> x86/svm_tests.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/x86/svm_tests.c b/x86/svm_tests.c
> index 2b84e4d..65008ba 100644
> --- a/x86/svm_tests.c
> +++ b/x86/svm_tests.c
> @@ -1480,6 +1480,7 @@ static void nmi_hlt_test(struct svm_test *test)
> if (!nmi_fired) {
> report(nmi_fired, "intercepted pending NMI not dispatched");
> set_test_stage(test, -1);
> + vmmcall();
> }
>
> set_test_stage(test, 3);
>

Queued, thanks.

Paolo