Re: [PATCH] drm/i915/gem: Fix inconsistent IS_ERR and PTR_ERR

[Markus Elfring]

â
> The proper pointer to be passed as argument is ce.
>
> This bug was detected with the help of Coccinelle.

My software development attention was caught also by your commit message.


â
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> @@ -1325,7 +1325,7 @@ static int __reloc_gpu_alloc(struct i915_execbuffer *eb,
>
>  		ce = intel_context_create(engine);
>  		if (IS_ERR(ce)) {
> -			err = PTR_ERR(rq);
> +			err = PTR_ERR(ce);
>  			goto err_unpin;
>  		}
>

Are you looking for any more questionable identifier (or expression) combinations
also at other places by the means of advanced source code analysis?

Regards,
Markus