Re: [PATCH v3] nfp: abm: Fix incomplete release of system resources in nfp_abm_vnic_set_mac()

[Jakub Kicinski]

On Sun,  3 May 2020 15:49:32 -0500 wu000273@xxxxxxx wrote:
> From: Qiushi Wu <wu000273@xxxxxxx>
> 
> In function nfp_abm_vnic_set_mac, pointer nsp is allocated by nfp_nsp_open.
> But when nfp_nsp_has_hwinfo_lookup fail, the pointer is not released,
> which can lead to a memory leak bug. Thus add a call of the function
> ânfp_nsp_closeâ for the completion of the exception handling.
> 
> Fixes: f6e71efdf9fb1 ("nfp: abm: look up MAC addresses via management FW")
> Signed-off-by: Qiushi Wu <wu000273@xxxxxxx>

This just makes the code longer. v1 was perfectly fine, thanks for the
fix.