Re: [PATCH 0/3] KVM: x86: cleanup and fixes for debug register accesses

[Peter Xu]

On Mon, May 04, 2020 at 11:55:55AM -0400, Paolo Bonzini wrote:
> The purpose of this series is to get rid of the get_dr6 accessor
> and, on Intel, of set_dr6 as well.  This is done mostly in patch 2,
> since patch 3 is only the resulting cleanup.  Patch 1 is a related
> bug fix that I found while inspecting the code.

Reviewed-by: Peter Xu <peterx@xxxxxxxxxx>

(Btw, the db_interception() change in patch 2 seems to be a real fix to me)

> 
> A guest debugging selftest is sorely needed if anyone wants to take
> a look!

I have that in my list, but I don't know it's "sorely" needed. :) It was low
after I knew the fact that we've got one test in kvm-unit-test, but I can for
sure do that earlier.

I am wondering whether we still want a test in selftests if there's a similar
test in kvm-unit-test already.  For this one I guess at least the guest debug
test is still missing.

Thanks,

-- 
Peter Xu