Re: [PATCH 5/5] sysctl: pass kernel pointers to ->proc_handler
From: Christoph Hellwig
Date: Tue May 05 2020 - 01:57:11 EST
On Mon, May 04, 2020 at 12:01:11PM -0700, Kees Cook wrote:
> > if (error)
> > - goto out;
> > + goto out_free_buf;
> >
> > /* careful: calling conventions are nasty here */
>
> Is this comment still valid after doing these cleanups?
The comment is pretty old so I decided to keep it. That being said
I'm not sure it really is very helpful.