Re: [PATCH net v1] net: broadcom: fix a mistake about ioremap resource

[Dejin Zheng]

On Mon, May 04, 2020 at 08:28:52PM -0700, Florian Fainelli wrote:
> 
> 
> On 5/4/2020 7:03 PM, Dejin Zheng wrote:
> > Commit d7a5502b0bb8b ("net: broadcom: convert to
> > devm_platform_ioremap_resource_byname()") will broke this driver.
> > idm_base and nicpm_base were optional, after this change, they are
> > mandatory. it will probe fails with -22 when the dtb doesn't have them
> > defined. so revert part of this commit and make idm_base and nicpm_base
> > as optional.
> > 
> > Fixes: d7a5502b0bb8bde ("net: broadcom: convert to devm_platform_ioremap_resource_byname()")
> > Reported-by: Jonathan Richardson <jonathan.richardson@xxxxxxxxxxxx>
> > Cc: Scott Branden <scott.branden@xxxxxxxxxxxx>
> > Cc: Ray Jui <ray.jui@xxxxxxxxxxxx>
> > Cc: Florian Fainelli <f.fainelli@xxxxxxxxx>
> > Cc: David S. Miller <davem@xxxxxxxxxxxxx>
> > Signed-off-by: Dejin Zheng <zhengdejin5@xxxxxxxxx>
> 
> Acked-by: Florian Fainelli <f.fainelli@xxxxxxxxx>

Florian, Thank you very much for helping me as always!

BR,
Dejin

> -- 
> Florian