Re: [PATCH] net: broadcom: fix a mistake about ioremap resource

From: Markus Elfring
Date: Tue May 05 2020 - 03:20:24 EST


> Commit d7a5502b0bb8b ("net: broadcom: convert to
> devm_platform_ioremap_resource_byname()") will broke this driver.
> idm_base and nicpm_base were optional, after this change, they are
> mandatory. it will probe fails with -22 when the dtb doesn't have them
> defined. so revert part of this commit and make idm_base and nicpm_base
> as optional.

I hope that other contributors can convince you to improve also this
commit message considerably.
Would you like to fix the spelling besides other wording weaknesses?

Regards,
Markus