Re: [trivial PATCH] efi/libstub: Reduce efi_printk object size
From: Joe Perches
Date: Tue May 05 2020 - 04:01:44 EST
On Tue, 2020-05-05 at 09:50 +0200, Ard Biesheuvel wrote:
> On Mon, 4 May 2020 at 20:29, Joe Perches <joe@xxxxxxxxxxx> wrote:
> > Use a few more common kernel styles.
> >
> > Trivially reduce efi_printk object size by using a dereference to
> > a temporary instead of multiple dereferences of the same object.
> >
> > Use efi_printk(const char *str) and static or static const for its
> > internal variables.
> >
> > Use the more common form of while instead of a for loop.
> >
> > Change efi_char16_printk argument to const.
> >
> > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
>
> Thanks Joe.
No worries, it's not worth applying if
it's not good code. Just ignore it.
cheers, Joe