Re: [PATCH] media: sun8i: Fix an error handling path in deinterlace_runtime_resume()

From: Markus Elfring
Date: Tue May 05 2020 - 04:15:35 EST


> It is spurious to call 'clk_disable_unprepare()' when
> 'clk_prepare_enable()' has not been called yet.

Can it be that the usage of the word âsuspiciousâ would be more appropriate
for such a change description?


> Re-order the error handling path to avoid it.

Would it be also helpful to explicitly mention in the commit message
that you would like to move a call of the function âclk_rate_exclusive_putâ
to the end of this function implementation for the correction
of the desired exception handling?

Regards,
Markus