RE: Re: [v3,iproute2 1/2] iproute2:tc:action: add a gate control action

From: Po Liu
Date: Tue May 05 2020 - 05:28:14 EST


Hi Stephen,

> -----Original Message-----
> From: Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx>
> Sent: 2020年5月5日 8:07
> To: Po Liu <po.liu@xxxxxxx>
> Cc: davem@xxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; vinicius.gomes@xxxxxxxxx; vlad@xxxxxxxxxx;
> Claudiu Manoil <claudiu.manoil@xxxxxxx>; Vladimir Oltean
> <vladimir.oltean@xxxxxxx>; Alexandru Marginean
> <alexandru.marginean@xxxxxxx>; michael.chan@xxxxxxxxxxxx;
> vishal@xxxxxxxxxxx; saeedm@xxxxxxxxxxxx; leon@xxxxxxxxxx;
> jiri@xxxxxxxxxxxx; idosch@xxxxxxxxxxxx;
> alexandre.belloni@xxxxxxxxxxx; UNGLinuxDriver@xxxxxxxxxxxxx;
> kuba@xxxxxxxxxx; xiyou.wangcong@xxxxxxxxx;
> simon.horman@xxxxxxxxxxxxx; pablo@xxxxxxxxxxxxx;
> moshe@xxxxxxxxxxxx; m-karicheri2@xxxxxx;
> andre.guedes@xxxxxxxxxxxxxxx
> Subject: Re: [v3,iproute2 1/2] iproute2:tc:action: add a gate control
> action
>
> On Sun, 3 May 2020 14:32:50 +0800
> Po Liu <Po.Liu@xxxxxxx> wrote:
>
> > + print_string(PRINT_ANY, "gate state", "\tgate-state %-8s",
>
> NAK
> Space in a json tag is not valid.
>
> Please run a dump command and feed it into JSON validation checker like
> Python.

I would test json format and upload new version patch set.

Thanks!
Br,
Po Liu