Re: [PATCH] scsi: qedi: remove unused variable udev & uctrl

[Lee Duncan]

On 5/5/20 5:19 AM, Xie XiuQi wrote:
> uctrl and udev are unused after commit 9632a6b4b747
> ("scsi: qedi: Move LL2 producer index processing in BH.")
> 
> Remove them.
> 
> Signed-off-by: Xie XiuQi <xiexiuqi@xxxxxxxxxx>
> ---
>  drivers/scsi/qedi/qedi_main.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
> index b995b19865ca..313f7e10aed9 100644
> --- a/drivers/scsi/qedi/qedi_main.c
> +++ b/drivers/scsi/qedi/qedi_main.c
> @@ -658,8 +658,6 @@ static struct qedi_ctx *qedi_host_alloc(struct pci_dev *pdev)
>  static int qedi_ll2_rx(void *cookie, struct sk_buff *skb, u32 arg1, u32 arg2)
>  {
>  	struct qedi_ctx *qedi = (struct qedi_ctx *)cookie;
> -	struct qedi_uio_dev *udev;
> -	struct qedi_uio_ctrl *uctrl;
>  	struct skb_work_list *work;
>  	struct ethhdr *eh;
>  
> @@ -698,9 +696,6 @@ static int qedi_ll2_rx(void *cookie, struct sk_buff *skb, u32 arg1, u32 arg2)
>  		  "Allowed frame ethertype [0x%x] len [0x%x].\n",
>  		  eh->h_proto, skb->len);
>  
> -	udev = qedi->udev;
> -	uctrl = udev->uctrl;
> -
>  	work = kzalloc(sizeof(*work), GFP_ATOMIC);
>  	if (!work) {
>  		QEDI_WARN(&qedi->dbg_ctx,
> 

Reviewed-by: Lee Duncan <lduncan@xxxxxxxx>

-- 
Lee