Re: [PATCH v4 2/6] dt-bindings: display: Add hpd-gpios to panel-common bindings

[Laurent Pinchart]

Hi Doug,

Thank you for the patch.

On Thu, Apr 30, 2020 at 12:46:13PM -0700, Douglas Anderson wrote:
> In the cases where there is no connector in a system there's no great
> place to put "hpd-gpios".  As per discussion [1] the best place to put
> it is in the panel.  Add this to the device tree bindings.
> 
> [1] https://lore.kernel.org/r/20200417180819.GE5861@xxxxxxxxxxxxxxxxxxxxxxxxxx
> 
> Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> ---
> 
> Changes in v4: None
> Changes in v3: None
> Changes in v2:
> - ("dt-bindings: display: Add hpd-gpios to panel-common...") new for v2
> 
>  .../devicetree/bindings/display/panel/panel-common.yaml     | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-common.yaml b/Documentation/devicetree/bindings/display/panel/panel-common.yaml
> index ed051ba12084..e9a04a3a4f5f 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-common.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-common.yaml
> @@ -96,6 +96,12 @@ properties:
>        (hot plug detect) signal, but the signal isn't hooked up so we should
>        hardcode the max delay from the panel spec when powering up the panel.
>  
> +  hpd-gpios:
> +    maxItems: 1
> +    description:
> +      If Hot Plug Detect (HPD) is connected to a GPIO in the system rather
> +      than a dedicated HPD pin the pin can be specified here.
> +
>    # Control I/Os
>  
>    # Many display panels can be controlled through pins driven by GPIOs. The nature

-- 
Regards,

Laurent Pinchart