Re: [PATCH] Kbuild: disable FORTIFY_SOURCE on clang-10
From: Kees Cook
Date: Tue May 05 2020 - 22:53:14 EST
On Tue, May 05, 2020 at 04:36:49PM -0700, Nick Desaulniers wrote:
> On Tue, May 5, 2020 at 4:22 PM Jason A. Donenfeld <Jason@xxxxxxxxx> wrote:
> >
> > On Tue, May 5, 2020 at 5:19 PM Kees Cook <keescook@xxxxxxxxxxxx> wrote:
> > >
> > > (Though as was mentioned, it's likely that FORTIFY_SOURCE isn't working
> > > _at all_ under Clang, so I may still send a patch to depend on !clang
> > > just to avoid surprises until it's fixed, but I haven't had time to
> > > chase down a solution yet.)
>
> Not good. If it's completely broken, turn it off, and we'll prioritize fixing.
The problem is what George mentioned: it's unclear how broken it is --
it may not be all uses. I haven't had time to finish the testing for it,
but it's on the TODO list. :)
--
Kees Cook