Re: [RFC PATCH] cpufreq: add support for HiSilicon SoC HIP09

[Hanjun Guo]

Hi Sudeep,

On 2020/4/30 17:55, Sudeep Holla wrote:
> On Thu, Apr 30, 2020 at 02:19:59PM +0800, Xiongfeng Wang wrote:
> > HiSilicon SoC has a separate System Control Processor(SCP) dedicated for
> > clock frequency adjustment and has been using the cpufreq driver
> > 'cppc-cpufreq'. New HiSilicon SoC HIP09 add support for CPU Boost, but
> > ACPI CPPC doesn't support this. In HiSilicon SoC HIP09, each core has
> > its own clock domain. It is better for the core itself to adjust its
> > frequency when we require fast response. In this patch, we add a
> > separate cpufreq driver for HiSilicon SoC HIP09.
>
> I disagree with this approach unless you have tried to extend the CPPC
> in ACPI to accommodate this boost feature you need. Until you show those
> efforts and disagreement to do that from ASWG, I am NACKing this approach.

Unfortunately we are not in ASWG at now, could you please give some
help about extending CPPC in ACPI to support boost feature?

Thanks
Hanjun