Re: [PATCH 1/2] net: qrtr: Add MHI transport layer

From: David Miller
Date: Wed May 06 2020 - 16:49:47 EST


From: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
Date: Wed, 6 May 2020 10:20:14 +0530

> +/* From QRTR to MHI */
> +static void qcom_mhi_qrtr_ul_callback(struct mhi_device *mhi_dev,
> + struct mhi_result *mhi_res)
> +{
> + struct sk_buff *skb = (struct sk_buff *)mhi_res->buf_addr;

You never need to cast to another pointer type from "void *", that's
the whole point of a void pointer.

So please remove this "struct sk_buff *" cast, thank you.

Please audit your entire submission for this problem.