Re: [PATCH] drm/vkms: enable cursor by default

[Rodrigo Siqueira]

Applied to drm-misc-next.

On 03/24, Rodrigo Siqueira wrote:
> Hi Melissa,
> 
> First of all, thanks for your patch.
> 
> I agree with you, it makes more sense to me if we enable cursors by
> default. I don't remember why we decided to add it as a disabled by
> default.
> 
> Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@xxxxxxx>
> 
> On 03/21, Melissa Wen wrote:
> > This patch proposes a change in the behavior of the cursor to enable it as
> > soon as the vkms module is added. Enabling the cursor by default appears
> > to be an expected and more friendly behavior, especially when running IGT
> > tests.
> > 
> > Signed-off-by: Melissa Wen <melissa.srw@xxxxxxxxx>
> > ---
> >  drivers/gpu/drm/vkms/vkms_drv.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
> > index 860de052e820..6e6feecf7f20 100644
> > --- a/drivers/gpu/drm/vkms/vkms_drv.c
> > +++ b/drivers/gpu/drm/vkms/vkms_drv.c
> > @@ -34,7 +34,7 @@
> >  
> >  static struct vkms_device *vkms_device;
> >  
> > -bool enable_cursor;
> > +bool enable_cursor = true;
> >  module_param_named(enable_cursor, enable_cursor, bool, 0444);
> >  MODULE_PARM_DESC(enable_cursor, "Enable/Disable cursor support");
> >  
> > -- 
> > 2.25.1
> > 
> 
> -- 
> Rodrigo Siqueira
> https://siqueira.tech



-- 
Rodrigo Siqueira
https://siqueira.tech

Attachment: signature.asc
Description: PGP signature