Re:[PATCH] drm/exynos: make pointer to const data const type

[Bernard]

From: Bernard Zhao <bernard@xxxxxxxx>
Date: 2020-04-26 17:01:42
To:  Inki Dae <inki.dae@xxxxxxxxxxx>,Joonyoung Shim <jy0922.shim@xxxxxxxxxxx>,Seung-Woo Kim <sw0312.kim@xxxxxxxxxxx>,Kyungmin Park <kyungmin.park@xxxxxxxxxxx>,David Airlie <airlied@xxxxxxxx>,Daniel Vetter <daniel@xxxxxxxx>,Kukjin Kim <kgene@xxxxxxxxxx>,Krzysztof Kozlowski <krzk@xxxxxxxxxx>,dri-devel@xxxxxxxxxxxxxxxxxxxxx,linux-arm-kernel@xxxxxxxxxxxxxxxxxxx,linux-samsung-soc@xxxxxxxxxxxxxxx,linux-kernel@xxxxxxxxxxxxxxx
Cc:  opensource.kernel@xxxxxxxx,Bernard Zhao <bernard@xxxxxxxx>
Subject: [PATCH] drm/exynos: make pointer to const data const type>Maybe keep pointer which points to global const string data
>in const type is better, make sure not change const data.
>
>Signed-off-by: Bernard Zhao <bernard@xxxxxxxx>
>---
> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 +-
> drivers/gpu/drm/exynos/exynos_drm_mic.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
>index e080aa92338c..f60d99c85ac9 100644
>--- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
>+++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
>@@ -211,7 +211,7 @@
> 
> #define OLD_SCLK_MIPI_CLK_NAME "pll_clk"
> 
>-static char *clk_names[5] = { "bus_clk", "sclk_mipi",
>+static const char *const clk_names[5] = { "bus_clk", "sclk_mipi",
> 	"phyclk_mipidphy0_bitclkdiv8", "phyclk_mipidphy0_rxclkesc0",
> 	"sclk_rgb_vclk_to_dsim0" };
> 
>diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
>index f41d75923557..a86abc173605 100644
>--- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
>+++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
>@@ -88,7 +88,7 @@
> 
> #define MIC_BS_SIZE_2D(x)	((x) & 0x3fff)
> 
>-static char *clk_names[] = { "pclk_mic0", "sclk_rgb_vclk_to_mic0" };
>+static const char *const clk_names[] = { "pclk_mic0", "sclk_rgb_vclk_to_mic0" };
> #define NUM_CLKS		ARRAY_SIZE(clk_names)
> static DEFINE_MUTEX(mic_mutex);
> 
>-- 
>2.26.2
>