Re: [PATCH 06/11] net: ethernet: mtk-eth-mac: new driver

From: Bartosz Golaszewski
Date: Thu May 07 2020 - 06:50:29 EST


czw., 7 maj 2020 o 11:46 Mark-MC.Lee <Mark-MC.Lee@xxxxxxxxxxxx> napisaÅ(a):
>
> Hi Bartosz:
> I think the naming of this driver and its Kconfig option is too generic
> that will confuse with current mediatek SoCs eth driver architecture(for
> all mt7xxx SoCs).
> Since mtk_eth_mac.c is not a common MAC part for all mediatek SoC but
> only a specific eth driver for mt85xx, it will be more reasonable to
> name it as mt85xx_eth.c and change NET_MEDIATEK_MAC to
> NET_MEDIATEK_MT85XX. How do you think?
>

Hi Mark,

I actually consulted this with MediaTek and the name is their idea.
Many drivers in drivers/net/ethernet have very vague names. I guess
this isn't a problem.

Bart