Re: [PATCHv2] iommu/arm-smmu: Make remove callback message more informative

[Sai Prakash Ranjan]

On 2020-05-07 16:03, Robin Murphy wrote:
> On 2020-05-07 11:04 am, Sai Prakash Ranjan wrote:
> > Hi,
> >
> > On 2020-05-07 05:40, Doug Anderson wrote:
> > > Hi,
> > >
> > > On Thu, Apr 23, 2020 at 7:35 AM Doug Anderson <dianders@xxxxxxxxxxxx> 
> > > wrote:
> > > > Hi,
> > > >
> > > > On Thu, Apr 23, 2020 at 2:55 AM Sai Prakash Ranjan
> > > > <saiprakash.ranjan@xxxxxxxxxxxxxx> wrote:
> > > > >
> > > > > Currently on reboot/shutdown, the following messages are
> > > > > displayed on the console as error messages before the
> > > > > system reboots/shutdown as part of remove callback.
> > > > >
> > > > > On SC7180:
> > > > >
> > > > >ÂÂ arm-smmu 15000000.iommu: removing device with active domains!
> > > > >ÂÂ arm-smmu 5040000.iommu: removing device with active domains!
> > > > >
> > > > > Make this error message more informative and less scary.
> > > > >
> > > > > Reported-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> > > > > Suggested-by: Robin Murphy <robin.murphy@xxxxxxx>
> > > > > Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@xxxxxxxxxxxxxx>
> > > > > ---
> > > > >Â drivers/iommu/arm-smmu.c | 2 +-
> > > > >Â 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> > >
> > > Is this patch waiting on anything in particular now? Do we need
> > > reviews from Robin and/or Will?
> >
> > Waiting for their reviews as they are the maintainers/reviewers :)
>
> Sorry, this did register at the time, I just felt that it's a bit
> redundant to give a review tag to say "yes, this is exactly what I
> suggested" :)
>
> That said, I do wish I hadn't forgotten about the dev_notice message
> level, but I think that lies over in the conceptual purity corner
> rather than making any practical difference, so I'm still OK with the
> patch as-is. Will?

I can change to dev_notice if you have strong preference for that.
I chose dev_info since we see the messages on every reboot and that 
makes
it more informational than something to notice everytime.

> p.s. whoever has this entry in their address book for the IOMMU list 
> (Doug?):
>
> "list@xxxxxxx:IOMMU DRIVERS <iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx>, Joerg
> Roedel <joro@xxxxxxxxxx>," <iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx>
>
> it really messes up Thunderbird's ability to generate working headers
> for a reply ;)

Not me ;)

Thanks,
Sai
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a 
member
of Code Aurora Forum, hosted by The Linux Foundation