Re: [PATCH 3/4] ARM: dts: stm32: enable stmpe811 on stm32429-disco board

[Alexandre Torgue]

On 5/7/20 2:13 PM, Hua Dillon wrote:
> hi, alexandre torgue
>
> so, if i add "---" below
>  ÂSigned-off-by: dillon min <dillon.minfei@xxxxxxxxx 
> <mailto:dillon.minfei@xxxxxxxxx>>
>  Âin git commit process, with changes log after that. the log will not 
> show in commit messages, but will exist in git patchs, just showing for 
> reviewers ?

Sorry I was not enough clear. Add --- after your signed-off and add your 
log change after

> i will try this tomorrow, resubmit it.
>
> thanks for your help.
>
> best regards
>
> dillon
>
> å 2020å5æ7æææåïAlexandre Torgue <alexandre.torgue@xxxxxx 
> <mailto:alexandre.torgue@xxxxxx>> åéï
>
>     Hi Dillon
>
>     On 5/7/20 1:15 PM, dillon.minfei@xxxxxxxxx
>     <mailto:dillon.minfei@xxxxxxxxx> wrote:
>
>         From: dillon min <dillon.minfei@xxxxxxxxx
>         <mailto:dillon.minfei@xxxxxxxxx>>
>
>         Enable the stmpe811 touch screen on stm32429-disco board.
>
>         Signed-off-by: dillon min <dillon.minfei@xxxxxxxxx
>         <mailto:dillon.minfei@xxxxxxxxx>>
>
>         [PATCH 3/4]: ARM: dts: stm32: enable stmpe811 on stm32429-disco
>
>         V2:
>         patch 3: remove unused id, blocks, irq-trigger
>
>         V1:
>         patch 4: fix read touch screen xyz timeout bug
>         patch 3: enable stmpe_touchscreen on stm32f429-disco board
>         patch 2: add i2c3 pin mux for stm32f4
>         patch 1: add i2c3 controller interface for stm32f4
>
>
>     Good idea to add changes log for this patch. But this log has to be
>     placed after "---" below. This log has not to appear in your commit
>     message. Furthermore, you should only add changes for this patch
>     without talking about other patches .
>
>
>         Signed-off-by: dillon min <dillon.minfei@xxxxxxxxx
>         <mailto:dillon.minfei@xxxxxxxxx>>
>         ---
>
>
>     Add patch change log here.
>
>          Â arch/arm/boot/dts/stm32f429-disco.dts | 47
>         +++++++++++++++++++++++++++++++++++
>          Â 1 file changed, 47 insertions(+)
>
>         diff --git a/arch/arm/boot/dts/stm32f429-disco.dts
>         b/arch/arm/boot/dts/stm32f429-disco.dts
>         index 30c0f67..fad1ec1 100644
>         --- a/arch/arm/boot/dts/stm32f429-disco.dts
>         +++ b/arch/arm/boot/dts/stm32f429-disco.dts
>         @@ -49,6 +49,8 @@
>          Â #include "stm32f429.dtsi"
>          Â #include "stm32f429-pinctrl.dtsi"
>          Â #include <dt-bindings/input/input.h>
>         +#include <dt-bindings/interrupt-controller/irq.h>
>         +#include <dt-bindings/gpio/gpio.h>
>          Â Â / {
>          Â Â Â Â model = "STMicroelectronics STM32F429i-DISCO board";
>         @@ -127,3 +129,48 @@
>          Â Â Â Â pinctrl-names = "default";
>          Â Â Â Â status = "okay";
>          Â };
>         +
>         +&i2c3 {
>         +Â Â Â Âpinctrl-names = "default";
>         +Â Â Â Âpinctrl-0 = <&i2c3_pins>;
>         +Â Â Â Âclock-frequency = <100000>;
>         +Â Â Â Âstatus = "okay";
>         +
>         +Â Â Â Âstmpe811@41 {
>         +Â Â Â Â Â Â Â Âcompatible = "st,stmpe811";
>         +Â Â Â Â Â Â Â Âreg = <0x41>;
>         +Â Â Â Â Â Â Â Âinterrupts = <15 IRQ_TYPE_EDGE_FALLING>;
>         +Â Â Â Â Â Â Â Âinterrupt-parent = <&gpioa>;
>         +Â Â Â Â Â Â Â Â/* 3.25 MHz ADC clock speed */
>         +Â Â Â Â Â Â Â Âst,adc-freq = <1>;
>         +Â Â Â Â Â Â Â Â/* 12-bit ADC */
>         +Â Â Â Â Â Â Â Âst,mod-12b = <1>;
>         +Â Â Â Â Â Â Â Â/* internal ADC reference */
>         +Â Â Â Â Â Â Â Âst,ref-sel = <0>;
>         +Â Â Â Â Â Â Â Â/* ADC converstion time: 80 clocks */
>         +Â Â Â Â Â Â Â Âst,sample-time = <4>;
>         +
>         +Â Â Â Â Â Â Â Âstmpe_touchscreen {
>         +Â Â Â Â Â Â Â Â Â Â Â Âcompatible = "st,stmpe-ts";
>         +Â Â Â Â Â Â Â Â Â Â Â Â/* 8 sample average control */
>         +Â Â Â Â Â Â Â Â Â Â Â Âst,ave-ctrl = <3>;
>         +Â Â Â Â Â Â Â Â Â Â Â Â/* 7 length fractional part in z */
>         +Â Â Â Â Â Â Â Â Â Â Â Âst,fraction-z = <7>;
>         +Â Â Â Â Â Â Â Â Â Â Â Â/*
>         +Â Â Â Â Â Â Â Â Â Â Â Â * 50 mA typical 80 mA max touchscreen
>         drivers
>         +Â Â Â Â Â Â Â Â Â Â Â Â * current limit value
>         +Â Â Â Â Â Â Â Â Â Â Â Â */
>         +Â Â Â Â Â Â Â Â Â Â Â Âst,i-drive = <1>;
>         +Â Â Â Â Â Â Â Â Â Â Â Â/* 1 ms panel driver settling time */
>         +Â Â Â Â Â Â Â Â Â Â Â Âst,settling = <3>;
>         +Â Â Â Â Â Â Â Â Â Â Â Â/* 5 ms touch detect interrupt delay */
>         +Â Â Â Â Â Â Â Â Â Â Â Âst,touch-det-delay = <5>;
>         +Â Â Â Â Â Â Â Â};
>         +
>         +Â Â Â Â Â Â Â Âstmpe_adc {
>         +Â Â Â Â Â Â Â Â Â Â Â Âcompatible = "st,stmpe-adc";
>         +Â Â Â Â Â Â Â Â Â Â Â Â/* forbid to use ADC channels 3-0 (touch) */
>         +Â Â Â Â Â Â Â Â Â Â Â Âst,norequest-mask = <0x0F>;
>         +Â Â Â Â Â Â Â Â};
>         +Â Â Â Â};
>         +};
>
>
>     _______________________________________________
>     linux-arm-kernel mailing list
>     linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
>     <mailto:linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>
>     http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>     <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>