Re: [patch V4 part 2 05/18] x86/entry: Move irq tracing on syscall entry to C-code

[Thomas Gleixner]

Thomas Gleixner <tglx@xxxxxxxxxxxxx> writes:
> Alexandre Chartre <alexandre.chartre@xxxxxxxxxx> writes:
>> On 5/5/20 3:41 PM, Thomas Gleixner wrote:
>>> -	/*
>>> -	 * User mode is traced as though IRQs are on, and the interrupt
>>> -	 * gate turned them off.
>>> -	 */
>>> -	TRACE_IRQS_OFF
>>> -
>>>   	movq	%rsp, %rdi
>>>   	call	do_int80_syscall_32
>>>   .Lsyscall_32_done:
>>> 
>>
>> enter_from_user_mode() is also called with the CALL_enter_from_user_mode macro,
>> which is used in interrupt_entry() and identry. Don't you need to also remove
>> the TRACE_IRQS_OFF there now?
>
> Hrm. right. OTOH, it's just redundant and should be no harm, but let me have a
> look at that again.

Grr, no. It'll trigger the warnon when context tracking is enabled. /me
scratches head and goes to fix.