Re: [PATCH 2/2] Input: add driver for power button on Dell Wyse 3020

[Dmitry Torokhov]

On Thu, May 07, 2020 at 07:46:44PM +0200, Pavel Machek wrote:
> Hi!
> 
> > +struct ec_input_response {
> > +	u8 reserved;
> > +	u8 msg_counter:2;
> > +	u8 count:2;
> > +	u8 type:4;
> > +	u8 data[3];
> > +} __packed;
> 

> Bitfields, and relying on them being in the right place for
> communication with hardware.
> 
> We don't usually do that, and there may be reasons why we don't. I'm
> pretty sure it breaks on big endian... and Im not sure if there's
> something else.

Usually it is endianness first and foremost, but this hardware is not
going to be used anywhere else...

-- 
Dmitry